Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle closing tag with whitespace #128

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

ashabhasa
Copy link
Contributor

This PR fixes a problem when parsing xml documents that have closing tags with trailing whitespace:

<foo>some-data</foo >

Copy link
Owner

@qcam qcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you that was an interesting fix. Could you please try out the following test case?

<foo>DATA</foo   bar >

and help to ensure that it fails :)

@ashabhasa
Copy link
Contributor Author

ashabhasa commented May 6, 2024

Thank you that was an interesting fix. Could you please try out the following test case?

<foo>DATA</foo   bar >

and help to ensure that it fails :)

Thank you for the feedback, I've added a test that makes sure the parsing fails when a node like the following is present

<foo>DATA</foo   bar >

@lucazulian
Copy link

@qcam, any updates on this issue? 🙏🏽

@qcam qcam merged commit daff30c into qcam:master Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants