WebUI: Enable virtual list for all tables #23544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehcneko
force-pushed
the
webui-more-virtual-list
branch
from
e536f7f to
a41c1a2
Compare
tehcneko
force-pushed
the
webui-more-virtual-list
branch
from
a41c1a2 to
3b97a4f
Compare
Chocobo1
reviewed
Nov 28, 2025
| setupVirtualList() { | ||
| super.setupVirtualList(); | ||
| this.rowHeight = 35; | ||
| } |
Comment on lines
+3081
to
+3085
| let statusImg; | ||
| switch (status) { | ||
| case "default": | ||
| statusImg = "images/application-rss.svg"; | ||
| break; |
Member
There was a problem hiding this comment.
Suggested change
| let statusImg; | |
| switch (status) { | |
| case "default": | |
| statusImg = "images/application-rss.svg"; | |
| break; | |
| let statusImg = "images/application-rss.svg"; | |
| switch (status) { |
|
|
||
| td.style.overflow = "visible"; | ||
| const indentation = row.full_data.indentation; | ||
| td.style.paddingLeft = `${indentation * 32 + 4}px`; |
Member
There was a problem hiding this comment.
Suggested change
| td.style.paddingLeft = `${indentation * 32 + 4}px`; | |
| td.style.paddingLeft = `${(indentation * 32) + 4}px`; |
| td.title = value; | ||
|
|
||
| const indentation = row.full_data.indentation; | ||
| td.style.paddingLeft = `${indentation * 32 + 4}px`; |
Member
There was a problem hiding this comment.
Suggested change
| td.style.paddingLeft = `${indentation * 32 + 4}px`; | |
| td.style.paddingLeft = `${(indentation * 32) + 4}px`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled virtual list for RSS and search engine tables.
CC @Piccirello