WebUI: Improve torrent deletion #21289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skomerko
commented
Sep 2, 2024
| MochaUI.centerWindow(w); | ||
| } | ||
| }); | ||
| if (LocalPreferences.get("confirm_torrent_deletion", "true") === "true") { |
There was a problem hiding this comment.
It was necessary to pretty much copy and paste it multiple times here and below in order to make confirm option work in all cases and to keep existing code intact. Currently, WebUI does not properly take into account selected filters (and filter terms) when performing "Start/stop/remove torrents" context menu actions. I'm going to improve this behavior in another PR and most of the repeated code from here will be gone. I just wanted to do things in proper order.
glassez
changed the title
skomerko
commented
Sep 3, 2024
skomerko
force-pushed
the
webui-torrent-deletion-improvements
branch
from
eb30884
to
8dfe1a8
Compare
Chocobo1
reviewed
Sep 6, 2024
skomerko
force-pushed
the
webui-torrent-deletion-improvements
branch
from
8dfe1a8
to
efc4e4e
Compare
Chocobo1
reviewed
Sep 6, 2024
skomerko
force-pushed
the
webui-torrent-deletion-improvements
branch
from
efc4e4e
to
a22c00f
Compare
Chocobo1
reviewed
Sep 7, 2024
skomerko
force-pushed
the
webui-torrent-deletion-improvements
branch
from
a22c00f
to
e9fef52
Compare
Chocobo1
approved these changes
Sep 8, 2024
thalieht
approved these changes
Sep 8, 2024
|
@skomerko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18345.
Everything should work like in GUI, so:
Confirm OFF:
When deleting selected torrents:
DEL / context menu: torrents deleted, files untouched
Shift + DEL: both deleted
When deleting by Category/Tag/Tracker:
Torrents deleted, files untouched
Confirm ON:
Should work like before, no changes there.