-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt into Windows SegmentHeap #21263
Opt into Windows SegmentHeap #21263
Conversation
Wrong schema setting being used!!! It needs to have it's own, see: https://learn.microsoft.com/en-au/windows/win32/sbscs/application-manifests#heaptype
|
b091aa1
to
81ec4df
Compare
81ec4df
to
e48a6f8
Compare
e48a6f8
to
d1a183a
Compare
src/qbittorrent.exe.manifest
Outdated
</asmv3:application> | ||
<application xmlns="urn:schemas-microsoft-com:asm.v3"> | ||
<windowsSettings> | ||
<!-- Enable Segment Heap, faster than NT Heap --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "faster than NT Heap" somehow troubles me. I've seen some reports about it being slower:
https://issues.chromium.org/issues/40138716
microsoft/Windows-Dev-Performance#106
@Andarwinux
Just curious, have you benchmarked qbt with it enabled?
You could just omit faster than NT Heap
and we'll be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SegmentHeap can greatly improve deallocating memory speed, see minetest/minetest#14127 and mpv-player/mpv#13137, which will improve exit speed when qBittorrent has a huge memory cache (32GB). But yes, on the other hand it does reduce performance in some extreme cases.
d1a183a
to
5ac880d
Compare
SegmentHeap provides a faster malloc implementation that only available with Dynamic UCRT in Windows 10, version 2004 (build 19041) and later
Unsure if comment is ok "as-is", but some alternatives:
|
5ac880d
to
d883176
Compare
@Andarwinux |
SegmentHeap provides a faster malloc implementation that only available with Dynamic UCRT in Windows 10, version 2004 (build 19041) and later