Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS: Adding Bengali and Hindi languages #20713

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Javed-ahmed-shanto
Copy link

Adding Bengali Translating strings used in NSIS installer
adding Bengali language strings

@luzpaz luzpaz added the NSIS NSIS installer related label Apr 16, 2024
@Javed-ahmed-shanto
Copy link
Author

Added Hindi Language file (hindi.nsh)

@luzpaz luzpaz changed the title Adding the language of Bengali (bengali.nsh file) in installation … NSIS: Adding Bengali and Hindi languages Apr 18, 2024
@Javed-ahmed-shanto
Copy link
Author

Any update on the approval?

@glassez
Copy link
Member

glassez commented Apr 28, 2024

Any update on the approval?

Did you test it?
IIRC, it won't work if you just add translation for some language, unless NSIS itself provides support for that language.

@schnurlos
Copy link
Contributor

I've just checked with the actual NSIS documentation.
Hindi could be added (included in Language files), Bengali not (same issue as Filipino/Tagalog ...).
Hindi language already is included in NSIS "SConscript" file.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 2, 2024

@Javed-ahmed-shanto ☝️

@Javed-ahmed-shanto
Copy link
Author

I have deleted the Bengali language from here, so you can approve the Hindi language for now.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 2, 2024

@Javed-ahmed-shanto does the Hindi translation work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSIS NSIS installer related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants