Add buttons to select/check files based on filter

[ColinKinloch]

This makes it easy to mark a subset of a deep directory structure of files for download.

If I want to download all the qBittorrent source code apart from the header files:

Filter by *.h and select all that match	Mark them to not be downloaded

This needs some UX work to avoid confusion:
Select All/None mark files for download.
"Select Selected" does the same for the selected items.
"Check all" would imply verifying (rechecking) the downloads.
Maybe "Highlight Matched" and "Select Highlighted" would be better.
Maybe "Select All" should become "Mark All".

[thalieht]

IMO there is no need for the extra buttons. Select all/none should apply to whatever has passed the filter.
That's my opinion you should wait for others too.

[xavier2k6]

Why don't you just put the *.h in the file exclusion list???

[ColinKinloch]

@xavier2k6
I can see that option under "Downloads" preferences panel.
Is there a way to apply that to a specific torrent?

[xavier2k6]

Is there a way to apply that to a specific torrent?

Not that I'm aware of.

[ColinKinloch]

I just had a quick look:

• What's the use-case for the global blocklist? I'm thinking something like *.exe for security purposes.
• Is there/should there be some indication that a file is not downloading due to the global blocklist?

[stalkerok]

IMO there is no need for the extra buttons. Select all/none should apply to whatever has passed the filter.

The current implementation would be more versatile:
Don't have to reset the filter to select all/none.
Can select files with a certain extension to give them a different download priority.

[stalkerok]

The select matches button works strangely, as if it doesn't select anything. When trying to set a different priority to the selected files, it applies only to the one I clicked on myself.

[ColinKinloch]

The select matches button works strangely

Ah, one thing that I found confusing writing this change selectionModel()->selectedRows(0) wouldn't contain anything when selected via selectionModel()->select(...), instead I had to use selectionModel()->selectedIndexes().

The select and deselect buttons seem to act as expected on mouse selected items.

One solution would be to change the other instances of selectedRows(0) to selectedIndexes().

Anyone with a good understanding of QTreeViews and an opinion?

[github-actions]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

[stalkerok]

Who can help with this PR?

[github-actions]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

[luzpaz]

@skomerko any chance you can resurrect this PR ?

[stalkerok]

@ColinKinloch ?

[ColinKinloch]

I'm happy to continue working on it. I'm not happy with the UI, I'm just not sure what it should look like.

As it says in my initial comment the button labels are confusing.

It just occurred to me: I've never seen a torrent that isn't a single file or doesn't have a single root folder.
Therefore are the "Select All" "Select None" worth keeping around? Considering you can just toggle the box on to the root folder?

[stalkerok]

Therefore are the "Select All" "Select None" worth keeping around? Considering you can just toggle the box on to the root folder?

The buttons have been around for a long time, I don't think they should be removed. Perhaps someone can suggest a better name for the new buttons.

[thalieht]

It just occurred to me: I've never seen a torrent that isn't a single file or doesn't have a single root folder.

Me neither but in the past people claimed that they have. Anyway it doesn't matter because qBt has an option to "Don't create subfolder" (root folder).

[github-actions]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.