Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-allow to use icons from system theme #18195

Merged
merged 4 commits into from
Dec 25, 2022
Merged

Re-allow to use icons from system theme #18195

merged 4 commits into from
Dec 25, 2022

Conversation

glassez
Copy link
Member

@glassez glassez commented Dec 10, 2022

No description provided.

@glassez glassez added Look and feel Affect UI "Look and feel" only without changing the logic GUI GUI-related issues/changes labels Dec 10, 2022
@Pentaphon Pentaphon mentioned this pull request Dec 10, 2022
Open
@Pentaphon
Copy link

All these theme changes are going to make it for 4.5.1 right? Otherwise people will keep complaining after every point release.

@glassez
Copy link
Member Author

glassez commented Dec 10, 2022

All these theme changes are going to make it for 4.5.1 right?

There is no particular milestone for it.

Otherwise people will keep complaining after every point release.

I don't care much. Let everything take its course. If it is approved and merged before the release of version 4.5.1, then I don't mind backporting it there.

@glassez glassez added the OS: Linux Issues specific to Linux distributions label Dec 12, 2022
@glassez glassez marked this pull request as ready for review December 12, 2022 14:41
@glassez glassez requested review from sledgehammer999 and a team December 12, 2022 14:42
@glassez glassez added this to the 4.6.0 milestone Dec 12, 2022
@glassez
Copy link
Member Author

glassez commented Dec 12, 2022

I'm done!
It can be said that I returned it to the same state as if we hadn't deleted such a feature. qBittorrent still looks like a "Frankenstein's monster" when "system icons" are enabled (however, as before) due to the fact that the system icons are mixed with custom ones, but this is no longer my concern. If anyone wants to improve it, PRs are welcome.

@thalieht

This comment was marked as resolved.

Sign in to view
@glassez

This comment was marked as resolved.

Sign in to view
@maboroshin

This comment was marked as off-topic.

Sign in to view
@glassez

This comment was marked as off-topic.

Sign in to view
sledgehammer999
sledgehammer999 reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@sledgehammer999 sledgehammer999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the fallback icon IDs. I trust that copied them from the old code correctly.

src/gui/uithememanager.cpp Show resolved Hide resolved
@glassez glassez merged commit cfd0c54 into qbittorrent:master Dec 25, 2022
@glassez glassez deleted the ui-theme branch December 25, 2022 13:26
glassez added a commit to glassez/qBittorrent that referenced this pull request Dec 25, 2022
@glassez
Re-allow to use icons from system theme
de15907 
PR qbittorrent#18195.
@glassez glassez mentioned this pull request Dec 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledgehammer999 sledgehammer999 sledgehammer999 approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic OS: Linux Issues specific to Linux distributions
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@glassez @Pentaphon @thalieht @maboroshin @sledgehammer999