Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright and license updates #17705

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

sledgehammer999
Copy link
Member

Long due update to the AUTHORS file.
Due to the inclusion of GPLv3+ icons (from #15769) the binary distribution of qbittorrent must be licensed accordingly. I made necessary changes to reflect that as best as possible.

@sledgehammer999 sledgehammer999 added this to the 4.5.0 milestone Sep 11, 2022
@sledgehammer999
Copy link
Member Author

sledgehammer999 commented Sep 11, 2022

@now-im can you confirm that the license for your own icons from #15769 is BSD 2-Clause?
PS: That's what you write in your repo.

This information exists in git's commit history and in the AUTHORS file.
@sledgehammer999
Copy link
Member Author

If someone can tell me how to fix the WebUI check, that would be nice.

@Mazino-Urek
Copy link
Contributor

Yes, it is BSD 2-Clause. But, I can change it to anything, as no one else has contributed to the repo.

@Chocobo1
Copy link
Member

If someone can tell me how to fix the WebUI check, that would be nice.

It is essentially a very long diff: https://github.com/qbittorrent/qBittorrent/runs/8296048465?check_suite_focus=true#step:6:75
You can either patch it manually or run the formatting on your local machine:

# after installing npm on your machine run:
cd src/webui/www
npm install
npm run lint
npm run format

@Chocobo1
Copy link
Member

As for the license updates, LGTM.

@sledgehammer999 sledgehammer999 merged commit d71ff73 into qbittorrent:master Sep 15, 2022
@sledgehammer999 sledgehammer999 deleted the gplv2_vs_gplv3 branch September 15, 2022 08:19
@sledgehammer999
Copy link
Member Author

For anyone reading: Now that this is merged, I can do a 4.5.0 beta release. My target is this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants