Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump boost requirement to 1.71 #16986

Merged
merged 1 commit into from
May 6, 2022
Merged

Bump boost requirement to 1.71 #16986

merged 1 commit into from
May 6, 2022

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented May 5, 2022

This is a prerequisite for using boost stacktrace.
Note that this is not the first version that introduces boost stacktrace but the version that should be stable enough.

Boost 1.71 is available on both debian, ubuntu:
https://packages.debian.org/bullseye/libboost-dev
https://packages.ubuntu.com/focal/libboost-dev

This is a prerequisite for using boost stacktrace.
Note that this is not the first version that introduces boost stacktrace but the version that
should be stable enough.
@Chocobo1 Chocobo1 added this to the 4.5.0 milestone May 5, 2022
@glassez
Copy link
Member

glassez commented May 5, 2022

This is a prerequisite for using boost stacktrace.

Well, you finally decided to look at Boost.Stacktrace 👍

@xavier2k6
Copy link
Member

Ubuntu 22.04 LTS Image will be available in GHA CI soon, we should up requirement then to Boost 1.74 as that brings previously discussed fixes.

https://packages.ubuntu.com/jammy/libboost-dev

@Chocobo1 Chocobo1 merged commit 763d172 into qbittorrent:master May 6, 2022
@Chocobo1 Chocobo1 deleted the boost branch May 6, 2022 03:20
@Chocobo1
Copy link
Member Author

Chocobo1 commented May 6, 2022

to Boost 1.74 as that brings previously discussed fixes.

I must have overlooked it, please remind me.

@xavier2k6
Copy link
Member

I must have overlooked it, please remind me.

More specifically it was an issue in asio which was fixed via Asio 1.16.1 & was then included in Boost 1.73+
https://www.boost.org/doc/libs/1_79_0/doc/html/boost_asio/history.html

Reference:
#15698 (comment)
#13511 (comment)
#11039 (comment)
#8740 (comment)


Also, there are more stacktrace fixes included in Boost 1.73/1.74

https://www.boost.org/users/history/version_1_73_0.html#:~:text=Stacktrace:
https://www.boost.org/users/history/version_1_74_0.html#:~:text=Stacktrace:

GHA CI (Public Beta)
actions/runner-images#5490

@Chocobo1
Copy link
Member Author

Chocobo1 commented May 10, 2022

Also, there are more stacktrace fixes included in Boost 1.73/1.74
https://www.boost.org/users/history/version_1_73_0.html#:~:text=Stacktrace:
https://www.boost.org/users/history/version_1_74_0.html#:~:text=Stacktrace:

FYI, those stacktrace fixes shouldn't affect us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants