Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAPI: allow to attach tags while adding torrents #13882

Merged
merged 2 commits into from
Dec 1, 2020
Merged

WebAPI: allow to attach tags while adding torrents #13882

merged 2 commits into from
Dec 1, 2020

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Nov 30, 2020

Adds an optional (some may say missing) field to /torrents/add WebAPI endpoint.

Both no-tag and with-tags cases are tested manually. The change works as intended.

@jesec jesec requested a review from Chocobo1 November 30, 2020 12:58
@FranciscoPombal FranciscoPombal added the WebAPI WebAPI-related issues/changes label Nov 30, 2020
@FranciscoPombal
Copy link
Member

Requires bumping the WebAPI version to 2.6.2. Also, can you add this functionality to the WebUI?

@jesec
Copy link
Contributor Author

jesec commented Nov 30, 2020

Requires bumping the WebAPI version to 2.6.2. Also, can you add this functionality to the WebUI?

No. I am not familiar with WebUI. I only use APIs.

glassez
glassez previously approved these changes Nov 30, 2020
@FranciscoPombal
Copy link
Member

No. I am not familiar with WebUI. I only use APIs.

OK, don't forget to bump the WebAPI version though.

@Chocobo1 Chocobo1 added this to the 4.3.2 milestone Dec 1, 2020
@glassez glassez merged commit e6c174c into qbittorrent:master Dec 1, 2020
@glassez
Copy link
Member

glassez commented Dec 1, 2020

Thank you!

IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Dec 1, 2020
WebAPI: allow to attach tags while adding torrents
@Ryrynz
Copy link

Ryrynz commented Dec 2, 2020

@jesec any chance of having a super nice extension to this functionality allowing qBittorrent to auto assign tags?
#7662
I'd only really like to see certain trackers assigned labels automatically when adding to the client (also from the webUI) Having tracker assigned auto tagging would be a nice first step to the above requested functionality.

@jesec
Copy link
Contributor Author

jesec commented Dec 5, 2020

@jesec any chance of having a super nice extension to this functionality allowing qBittorrent to auto assign tags?
#7662
I'd only really like to see certain trackers assigned labels automatically when adding to the client (also from the webUI) Having tracker assigned auto tagging would be a nice first step to the above requested functionality.

The change may allow an API user (possibly an application) to attach tags when it adds a torrent based on the watch folder. However, no function is implemented (and I don't plan to implement one) to allow the "auto-assigning" you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAPI WebAPI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants