Fix truncation when parsing HTTP request query #13042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
reviewed
Jun 19, 2020
Closes qbittorrent#13029. Fixes an issue with truncation of a QByteArray at the first '\0' byte when parsing HTTP request query strings. Previously, the operands of the ternary expression were of different types. Most likely this was leading to a conversion of the result to some kind of '\0'-terminated string type somewhere along the way, in turn causing its truncation at the first '\0' byte once converted back to QByteArray. For some reason this bug was only present on Windows (MSVC).
Prevents bugs like qbittorrent#13029, even if the ternary expression operands have different types.
FranciscoPombal
force-pushed
the
fix_request_parser
branch
from
a15824b
to
a1809a4
Compare
glassez
approved these changes
Jun 23, 2020
Chocobo1
approved these changes
Jun 23, 2020
Chocobo1
changed the title
|
Thank you! |
IceCodeNew
pushed a commit
to IceCodeNew/qBittorrent-Enhanced-Edition
that referenced
this pull request
Aug 28, 2020
…_parser Fix truncation when parsing HTTP request query
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13029.
\0byte when parsing HTTP request query strings.QT_NO_CAST_FROM_BYTEARRAYto compile definitions to prevent this class of bugs, even if different types are used in the ternary expression operands.