Redesigned Icons #12965

Mazino-Urek · 2020-06-02T16:52:32Z

Old icons posed two problems:

Barely visible in dark theme
Inconsistent icon sizes and colors
With this commit following changes were made:
Bright Icons which are equally visible in both white and dark theme
All icons using uniform canvas and only 6 colors
These icons have well visibility in the HDPI screen and thus future proof the application.

NotTsunami · 2020-06-03T15:13:38Z

Once again you need to update icons\icons.qrc

Mazino-Urek · 2020-06-03T18:26:14Z

@NotTsunami Sorry, this pesky little line made me suffer again and again. Fixed it.

ghost · 2020-07-12T04:33:08Z

You made really great changes to improve the horrible UI that qBt has. I wonder why these aren’t getting merged yet!

NotTsunami · 2020-07-30T06:48:56Z

@Chocobo1 @glassez What is your opinion moving forward with this patch? It appears to be ready to merge. I'm not sure if there is any conflict of interest with this and theming (although this looks like a nice improvement over the currently existing icon set).

@now-im I know you uploaded some screenshots in previous PRs, but could you upload a few that correspond to the latest parchset? I know some icons have changed since the first screenshot and it might aid in the review.

glassez · 2020-07-30T11:14:13Z

@glassez What is your opinion moving forward with this patch? It appears to be ready to merge.

I expressed my opinion in one of the incarnations of this PR: even if we approve this set of icons by itself, I think it's not a good idea to "change the look-and-feel" in the middle of releases - we should wait for a more major update.

I'm not sure if there is any conflict of interest with this and theming

Yes. But by releasing this set of icons as a theme, you would make it easier to review it "in real life".

Mazino-Urek · 2020-08-07T19:07:41Z

@now-im I know you uploaded some screenshots in previous PRs, but could you upload a few that correspond to the latest parchset? I know some icons have changed since the first screenshot and it might aid in the review.

Updated icon screenshots.

jagannatharjun · 2020-08-16T15:10:52Z

here is qbtheme with these icons set if anyone wants to try out
icon-theme.zip

PS: this will not work with 4.2.5, you have to compile qbittorrent yourself over the current master to try it out

Mazino-Urek · 2020-08-16T18:15:29Z

here is qbtheme with these icons set if anyone wants to try out
icon-theme.zip

PS: this will not work with 4.2.5, you have to compile qbittorrent yourself over the current master to try it out

Thanks a lot!

Mazino-Urek · 2020-09-18T05:08:38Z

@glassez @FranciscoPombal @Chocobo1 @sledgehammer999 Any chance this gets merged in version 4.3?

glassez · 2020-09-18T06:42:30Z

@glassez @FranciscoPombal Any chance this gets merged in version 4.3?

I don't mind.

ghost · 2020-10-13T13:41:23Z

@glassez @FranciscoPombal Any chance this gets merged in version 4.3?

I don't mind.

glassez if you guys plan to make the next release as 4.3.0 then I think this could get merged and included.

glassez · 2020-10-13T14:18:42Z

glassez if you guys plan to make the next release as 4.3.0 then I think this could get merged and included.

I think it should now be addressed to @sledgehammer999.

Mazino-Urek · 2020-10-16T05:23:42Z

@sledgehammer999 I know you are busy. But, I have worked on this project for a long time. I had to make changes again and again and work for countless hours just because some changes were made into the official repo and broke many things for my end.
Can I get a green light?

Old icons posed two problems: - Barely visible in dark theme - Inconsistent icon sizes and colors With this commit following changes were made: - Bright Icons which are equally visible in both white and dark theme - All icons using uniform canvas and only 6 colors These icons have well visibility in the HDPI screen and thus future proof the application.

ghost · 2020-10-17T04:30:55Z

@nowshed-imran
Personally, I don't like some of these icons.
Network-server.svg -> It doesn't look good in the TRACKERS section.
Firewalled.svg -> it stands out too much.
speedometer.svg -> It's too small.. People don't notice that icon anyway and you've made it even smaller.
Applicationexit.svg -> Again not a big fan of these red on white stuff..doesn't blend well..stands out too much...

Also for me, the download icon is still showing the old one. I'm using the theme supplied by jagannatharjun though.
https://gyazo.com/62b665631c36592897d11ec9fbaaa84f

Edit: I tried the build from actions as well and the download icon is not showing up at all.

ghost · 2020-10-17T04:46:11Z

Is it possible to make this as a configurable theme option rather than giving users no option to get back the old look?
I think some people may not like all the changes and may want the old look back.
I know it looks nice and fancy on screenshots but when you actually apply the theme the experience is different and I'm not sure everyone will like that. That's just my opinion though.

glassez · 2020-10-17T05:04:03Z

Is it possible to make this as a configurable theme option rather than giving users no option to get back the old look?

So I would suggest it to be distributed as theme bundle instead.

Mazino-Urek · 2020-10-17T08:16:07Z

Personally, I don't like some of these icons.
Network-server.svg -> It doesn't look good in the TRACKERS section.
Firewalled.svg -> it stands out too much.
speedometer.svg -> It's too small.. People don't notice that icon anyway and you've made it even smaller.
Applicationexit.svg -> Again not a big fan of these red on white stuff..doesn't blend well..stands out too much...

I have made the icon fill transparent so that it assumes the background color of the application. About the icon size of speedometer, the new theme now uses a uniform icon size so that it can have a uniform look. For that this icon suffered. It will help any future icon designer to have a good base to work with.

Edit: I tried the build from actions as well and the download icon is not showing up at all.

@FranciscoPombal @jagannatharjun Kindly help.

Preference varied person to person. If you look at the related previous git pull history is multiple, I have been changing these icons and colors again and again based on contributor's opinion. Some made great improvement, some I did just as majority wanted it.
I just can't keep doing it again and again. The enthusiasm I had at first, very little now remains.

So I would suggest it to be distributed as theme bundle instead.

I got no problem with that. But, I am no developer. I just happened to learn something about icon design when I tried to look my KDE desktop nice with la-capitaine-icon-theme. I was a student then. I have been using qBittorent for a long time. I had some free time and thought I could make some improvement it too.I did what I could while maintaing a full time job.

I am novice but I tried my level best and used standard practice so that other future professional designer can improve upon it too. I am neither a developer nor a designer. Hope you guys understand my dilemma.

But, this icons will stay in trend for a very long time. I can promise that.

ghost · 2020-10-17T09:19:16Z

Preference varied person to person. If you look at the related previous git pull history is multiple, I have been changing these icons and colors again and again based on contributor's opinion. Some made great improvement, some I did just as majority wanted it.
I just can't keep doing it again and again. The enthusiasm I had at first, very little now remains.

That's completely understandable. My point was to make this as a configurable theming option to allow such users to switch back to old icons if they wanted to.

Again that's just a personal opinion. If the devs or the maintainer wants they can merge it as the default icon as well.

FranciscoPombal · 2020-10-17T14:54:54Z

Edit: I tried the build from actions as well and the download icon is not showing up at all.

@FranciscoPombal @jagannatharjun Kindly help.

Unfortunately, I don't have time to be of more help right now, but I can confirm I can reproduce the problem. Look for typos/missing entries in the .qrc files.

jagannatharjun · 2020-10-17T15:25:10Z

works for me

I guess you're using it on ubuntu/linux, qt's apps static builds with CMake are not well supported

FranciscoPombal · 2020-10-17T15:30:18Z

@jagannatharjun

I guess you're using it on ubuntu/linux, qt's apps static builds with CMake are not well supported

I tested on Windows. On Ubuntu, I always test with dynamic builds. Also, the download icon in the status bar is also not showing in your screenshot.

jagannatharjun · 2020-10-17T15:34:15Z

@jagannatharjun

I guess you're using it on ubuntu/linux, qt's apps static builds with CMake are not well supported

I tested on Windows. On Ubuntu, I always test with dynamic builds. Also, the download icon in the status bar is also not showing in your screenshot.

opsie I thought nowshed asked the question and only read the quoted part
In master `downloding_small.svg' is used in for icon in status bar, this PR deletes that icon

jagannatharjun · 2020-10-17T15:38:08Z

In master `downloding_small.svg' is used in for icon in status bar, this PR deletes that icon

a better fix would be to use downloading.svg for this icon instance too

qBittorrent/src/gui/statusbar.cpp

Line 73 in 720c1c8

    
           m_dlSpeedLbl->setIcon(UIThemeManager::instance()->getIcon(QLatin1String("downloading_small")));

downloading.svg and downloading_small.svg is the same but download_small.svg has lower resolution IDK why such arrangement exits possibly for performance reason.

jagannatharjun · 2020-10-17T15:48:43Z

one more thing I actually been using your icons for quite some time really liked the designs not sure about the color choices though, I have been using them with different colors hope you don't mind

Mazino-Urek · 2020-10-25T17:39:09Z

@nowshed-imran commented on 2020. okt. 24. 11:19 CEST:

It is difficult to distinguish dark and light of same color. But, I tried.

Only brightness. How about decreasing saturation, and maybe shifting the hue slightly? I guess adding something would help. Like putting a an x or stop icon in the bottom right corner.

I think this is a better solution.
@jagannatharjun what do you say?

jagannatharjun · 2020-10-25T17:45:46Z

I think this is a better solution.
@jagannatharjun what do you say?

what it is for? stalled downloading/uploading? imho these icons should have inactive colors but easily distinguishable from the rest of the transfer list since the majority of torrents will be stalled uploading.

Mazino-Urek · 2020-10-26T17:30:49Z

I think this is a better solution.
@jagannatharjun what do you say?

what it is for? stalled downloading/uploading? imho these icons should have inactive colors but easily distinguishable from the rest of the transfer list since the majority of torrents will be stalled uploading.

I have changed it to dark grey. For small icons this complexity is unnecessary I guess.
I think the project is complete now.

jagannatharjun · 2020-11-05T12:43:39Z

on dark theme system, qBitTorrent uses dark blue font color for completed torrent but the icon is violet (or something, contrast is too much), also the stalled torrents have white font color but their icon is dark bluish this looks weird when the icons are mixed up

glassez · 2020-11-05T12:51:24Z

Seems it's impossible in common case to have the icon set that is equally suitable for dark and light themes. This is another reason to produce sets of icons in the form of theme bundles (or as part of theme bundles).

Mazino-Urek · 2020-11-05T13:03:00Z

on dark theme system, qBitTorrent uses dark blue font color for completed torrent but the icon is violet (or something, contrast is too much), also the stalled torrents have white font color but their icon is dark bluish this looks weird when the icons are mixed up

Let's see what I can do.

mzso · 2020-11-05T14:04:40Z

@glassez commented on 2020. nov. 5. 13:51 CET:

Seems it's impossible in common case to have the icon set that is equally suitable for dark and light themes. This is another reason to produce sets of icons in the form of theme bundles (or as part of theme bundles).

Seems like a lost cause. What is even the motivation. If the theme is different anyway, why would one want the icons the same?
(Or is it not possible right now to specify icons other than the default theme's?)

Mazino-Urek · 2020-11-05T16:29:46Z

@glassez commented on 2020. nov. 5. 13:51 CET:

Seems it's impossible in common case to have the icon set that is equally suitable for dark and light themes. This is another reason to produce sets of icons in the form of theme bundles (or as part of theme bundles).

Seems like a lost cause. What is even the motivation. If the theme is different anyway, why would one want the icons the same?
(Or is it not possible right now to specify icons other than the default theme's?)

I disagree. For linux this may seems like a waste of time and energy(ironically I use Linux) but for average Mac and Windows user this will be a great refresh. They will not bother changing theme manually. Other than the color dilemma the icon design change is a major upgrade in my opinion. Color can be fixed easily by other, it is the design change that takes most of the time.
Your suggestion is highly appreciated.

Mazino-Urek · 2020-11-05T16:35:02Z

@glassez
I have thought about it.
Is it possible to bundle two icon themes?
One for light and another for dark. Shape is same but color is suited for the background theme.
That way most of the problem can be solved.

jagannatharjun · 2020-11-05T16:36:28Z

one more thing why do you want so many colors in a single line (PS: replace pink with blue)

glassez · 2020-11-05T17:41:33Z

@glassez
I have thought about it.
Is it possible to bundle two icon themes?

Currently only one icon set is used at a time. Theme bundles just replace default icons.
But it shouldn't be a problem to implement the logic so that qBittorrent uses icons from a different folder if theme has dark colors. The only note is that it only makes sense for built-in icons, or for theme bundles that contain only icons.
@jagannatharjun?

Mazino-Urek · 2020-11-28T10:09:03Z

I am not getting any feedback.
@jagannatharjun @FranciscoPombal @Chocobo1 Can you help me?
The plan is to have two icon themes. One light and another dark.
qBittorent should be able to pick the right theme based on the system. Otherwise, at least provide the user the option to select the right one. I don't know how to code. I need some assistance here.

jagannatharjun · 2020-12-07T19:43:40Z

The plan is to have two icon themes. One light and another dark.
qBittorent should be able to pick the right theme based on the system. Otherwise, at least provide the user the option to select the right one.

you can check QPallete color to at least get a hint but there doesn't seem to be anything in Qt itself, you will have to use native functions which will not be reliable.

Mazino-Urek · 2020-12-08T06:04:15Z

@jagannatharjun These are like utter gibberish to me. I am not a developer and don't have time required to learn it.
This kind of settles it. Unless core developers implement native dark theme this project will not go anywhere.
I will not actively follow this PR anymore.

github-actions · 2021-08-12T00:46:34Z

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

Mazino-Urek · 2021-08-12T04:17:27Z

This PR has been marked stale. Should I close it?

mzso · 2021-08-12T14:52:27Z

@nowshed-imran commented on 2021. aug. 12. 06:17 CEST:

This PR has been marked stale. Should I close it?

So whatever becomes with the theme/icons?
I'm still using (the slightly glitched) the dark them variant shared by @jagannatharjun almost a year ago. It would be fine if the progress bar wasn't glitched.

Mazino-Urek · 2021-08-12T19:01:29Z

@nowshed-imran commented on 2021. aug. 12. 06:17 CEST:

This PR has been marked stale. Should I close it?

So whatever becomes with the theme/icons?
I'm still using (the slightly glitched) the dark them variant shared by @jagannatharjun almost a year ago. It would be fine if the progress bar wasn't glitched.

I honestly don't know. I have made honest effort and worked fairly hard while maintaining a full time job. I don't think core developers want to change the current icons. I sincerely thank Jagannath Arjun for making some use of the icon pack.

Mazino-Urek · 2021-08-14T19:49:02Z

Closing the PR as I didn't receive any feedback. Kindly point this PR to any future icon designer. I give permission to use these icons freely in any open source project.

tprepper · 2023-03-19T18:20:01Z

My above comment wasn't spam I'm just saying this looks bad and a redesign should've been made by someone who knows how to make one

tprepper · 2023-03-19T21:45:09Z

Weird, qbittorrent uses similar icons currently and they don't look very good. Apologies, this was uncalled for.

This was referenced Jun 2, 2020

Redesigned Icons #12926

Closed

Redesigned icons with svgcleaner optimization #12927

Closed

FranciscoPombal added the GUI GUI-related issues/changes label Jun 3, 2020

Transparent Icon Fill

9020890

Changing Readme

9bc7f0d

Reverting Stall Icon Colors

2dc95a2

xavier2k6 mentioned this pull request Dec 14, 2020

Enable native Windows 10 dark theme support by default #13952

Closed

github-actions bot added the Stale label Aug 12, 2021

github-actions bot removed the Stale label Aug 13, 2021

Mazino-Urek closed this Aug 14, 2021

This was referenced Sep 10, 2021

Redesigning Firewall Icon #15434

Closed

Redesign Icons #15453

Closed

Mazino-Urek mentioned this pull request Jun 8, 2022

Implement new icon/color theme #15769

Merged

30 tasks

This comment was marked as spam.

Sign in to view

Redesigned Icons #12965

Redesigned Icons #12965

Conversation

Mazino-Urek commented Jun 2, 2020 • edited Loading

NotTsunami commented Jun 3, 2020

Mazino-Urek commented Jun 3, 2020

ghost commented Jul 12, 2020

NotTsunami commented Jul 30, 2020 • edited Loading

glassez commented Jul 30, 2020 • edited Loading

Mazino-Urek commented Aug 7, 2020

jagannatharjun commented Aug 16, 2020

Mazino-Urek commented Aug 16, 2020

Mazino-Urek commented Sep 18, 2020 • edited Loading

glassez commented Sep 18, 2020

ghost commented Oct 13, 2020

glassez commented Oct 13, 2020

Mazino-Urek commented Oct 16, 2020 • edited Loading

ghost commented Oct 17, 2020 • edited by ghost Loading

ghost commented Oct 17, 2020

glassez commented Oct 17, 2020

Mazino-Urek commented Oct 17, 2020 • edited Loading

ghost commented Oct 17, 2020

FranciscoPombal commented Oct 17, 2020

jagannatharjun commented Oct 17, 2020

FranciscoPombal commented Oct 17, 2020

jagannatharjun commented Oct 17, 2020

jagannatharjun commented Oct 17, 2020

jagannatharjun commented Oct 17, 2020

Mazino-Urek commented Oct 25, 2020

jagannatharjun commented Oct 25, 2020 • edited Loading

Mazino-Urek commented Oct 26, 2020

jagannatharjun commented Nov 5, 2020 • edited Loading

glassez commented Nov 5, 2020

Mazino-Urek commented Nov 5, 2020

mzso commented Nov 5, 2020

Mazino-Urek commented Nov 5, 2020

Mazino-Urek commented Nov 5, 2020

jagannatharjun commented Nov 5, 2020

glassez commented Nov 5, 2020

Mazino-Urek commented Nov 28, 2020

jagannatharjun commented Dec 7, 2020

Mazino-Urek commented Dec 8, 2020 • edited Loading

github-actions bot commented Aug 12, 2021

Mazino-Urek commented Aug 12, 2021

mzso commented Aug 12, 2021

Mazino-Urek commented Aug 12, 2021

Mazino-Urek commented Aug 14, 2021

This comment was marked as spam.

tprepper commented Mar 19, 2023

tprepper commented Mar 19, 2023 • edited Loading

Mazino-Urek commented Jun 2, 2020 •

edited

Loading

NotTsunami commented Jul 30, 2020 •

edited

Loading

glassez commented Jul 30, 2020 •

edited

Loading

Mazino-Urek commented Sep 18, 2020 •

edited

Loading

Mazino-Urek commented Oct 16, 2020 •

edited

Loading

ghost commented Oct 17, 2020 •

edited by ghost

Loading

Mazino-Urek commented Oct 17, 2020 •

edited

Loading

jagannatharjun commented Oct 25, 2020 •

edited

Loading

jagannatharjun commented Nov 5, 2020 •

edited

Loading

Mazino-Urek commented Dec 8, 2020 •

edited

Loading

tprepper commented Mar 19, 2023 •

edited

Loading