Skip to content

Conversation

@KochTobi
Copy link
Contributor

@KochTobi KochTobi commented Jan 8, 2026

@KochTobi KochTobi requested a review from a team as a code owner January 8, 2026 09:02
@github-actions github-actions bot added the fix label Jan 8, 2026
Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KochTobi one comment i kindly would like a short feedback

<groupId>dev.sigstore</groupId>
<artifactId>sigstore-maven-plugin</artifactId>
<version>1.3.0</version>
<version>2.0.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a major version jump, can you verify that the build of sigstore files works still properly?

Copy link
Contributor Author

@KochTobi KochTobi Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sigstore files were created. .pom.sigstore.json and .jar.sigstore.json

Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment is obsolete, i verified locally and the Sigstore files are still created properly for every JAR and POM file.

@KochTobi KochTobi merged commit d738561 into main Jan 13, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants