Allow for multiple lights in the visualisation#24
Open
johanhvdb wants to merge 4 commits intoqbead:mainfrom
Open
Allow for multiple lights in the visualisation#24johanhvdb wants to merge 4 commits intoqbead:mainfrom
johanhvdb wants to merge 4 commits intoqbead:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the state class, so that merge will have to be done beforehand. Also makes the diff more difficult to read.
On the html side the set bloch smooth has been improved. It would only average out the theta and not the phi value. This looked weird in the visualisation. It would be a good idea to consider using the same code on the arduino side.
Every time set bloch smooth is called, the theta phi and c values are added to an array and sent to the laptop. Due to bluetooth max 20 bytes this is done in multiple times.
The first value in the array is treated as the main value (so the first call to set_bloch_smooth) and this is where the arrow points.