Repository navigation
fix(bug): fix the bug in unittest - #4
Merged
qbc2016 merged 1 commit intoNov 10, 2025
Merged
Conversation
DavdGao
added a commit
that referenced
this pull request
Aug 5, 2026
…i#10/agentscope-ai#12/agentscope-ai#13 + session name - agentscope-ai#10: allow all PermissionMode values for channel sessions. The engine resolves every mode server-side and the ASK path maps to the confirm card, so accept_edits/explore work too — drop the over-conservative allowlist, keep only a valid-enum check. - #4: gateway drops events for a since-disabled channel (record.enabled guarded in _handle_message and _handle_decision). - agentscope-ai#8: Feishu fetches its own bot open_id via /bot/v3/info and gates on the bot's own mention rather than any mention. - agentscope-ai#12: ChannelTypeRegistry.__bool__ + lifespan guards so the dispatcher is neither built nor started when no channel types are registered. - agentscope-ai#13: in-memory bus honors queue TTL (expire on push+drain) and caps the media buffer drain at _MEDIA_BUFFER_MAX. - session name shortened to "{channel_type}:{chat_id}". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DavdGao
added a commit
that referenced
this pull request
Aug 5, 2026
FeishuChannel ran lark's blocking ``client.start()`` on a daemon thread; it parks forever on ``run_until_complete(_select())``, so setting the stop flag and join(timeout=5) never made it return — the thread lingered and kept delivering events after the channel was disabled or updated. Capture the WS thread's own event loop and, in teardown (which the lifecycle dispatcher triggers via task.cancel() on disable/update), stop it via call_soon_threadsafe so client.start() unblocks, the thread exits, and join succeeds promptly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope Version
[The version of AgentScope you are working on, e.g.
import agentscope; print(agentscope.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand