Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement columns iterator #653

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Conversation

Jerome1337
Copy link
Contributor

PR Details

Implement worksheet columns iterator

Description

Create an iterator function that will loop over every columns
Create a Next() and Error() functions like the rows iterator

Related Issue

Fixes #648

Motivation and Context

In some cases it is very helpful to iterate over columns instead rows
For example reading or writing vertical table

How Has This Been Tested

Tested using Go tests
Manually tested inside a personal project depending on Excelize

Every tests has been run on Ubuntu 18.04 and Go 1.13.4

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #653 into master will decrease coverage by 0.03%.
The diff coverage is 91.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   96.45%   96.41%   -0.04%     
==========================================
  Files          30       30              
  Lines        8718     8789      +71     
==========================================
+ Hits         8409     8474      +65     
- Misses        189      192       +3     
- Partials      120      123       +3     
Impacted Files Coverage Δ
col.go 98.25% <91.54%> (-1.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce48b8...e9a4007. Read the comment docs.

@xuri xuri merged commit dcb772d into qax-os:master Jun 20, 2020
@xuri
Copy link
Member

xuri commented Jun 20, 2020

LGTM, thanks @Jerome1337!

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 20, 2020
col.go Show resolved Hide resolved
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide column iterator
3 participants