Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape html tag #647

Merged
merged 1 commit into from
Jun 8, 2020
Merged

escape html tag #647

merged 1 commit into from
Jun 8, 2020

Conversation

heiy
Copy link
Contributor

@heiy heiy commented Jun 8, 2020

PR Details

support html tag

use html.EscapeString to transform the html tag

Motivation and Context

if excel have html tag , it well be empty

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #647 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          30       30           
  Lines        8718     8718           
=======================================
  Hits         8409     8409           
  Misses        189      189           
  Partials      120      120           
Impacted Files Coverage Δ
cell.go 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dd764...eb150c0. Read the comment docs.

@xuri xuri merged commit 8ce48b8 into qax-os:master Jun 8, 2020
@xuri
Copy link
Member

xuri commented Jun 8, 2020

LGTM, thanks @heiy.

nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants