Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2457 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 32 32
Lines 32838 32845 +7
=======================================
+ Hits 32748 32755 +7
Misses 88 88
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blank cells were converted to numeric zero before every comparison. For a blank A1, this made
A1=""return FALSE andA1="0"return TRUE.Use an empty string when comparing a blank cell with text, FALSE when comparing it with a logical value, and zero otherwise. The change applies to all six comparison operators in either operand order.
Related Issue
Fixes #2449.
How Has This Been Tested
go test ./... -count=1 -timeout 20mgo test -race ./... -run '^TestCalc' -count=1 -timeout 10mgo vet ./...Tested with Go 1.27.1 on macOS arm64.
A full race-enabled run was also attempted, but the process was killed before completion.
Types of changes