feat: add formula shared index #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2118 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 32 32
Lines 30176 30205 +29
=======================================
+ Hits 29945 29974 +29
Misses 153 153
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Juneezee
reviewed
Apr 24, 2025
Juneezee
reviewed
Apr 25, 2025
xuri
added
the
size/M
xuri
requested changes
Apr 25, 2025
xuri
requested changes
Apr 25, 2025
xuri
requested changes
Apr 26, 2025
- Rename formulaSharedIndex to formulaSI - Remove deepcopy dependencies - Upgrade go-deepcopy to v1.5.2 - Update unit tests
xuri
force-pushed
the
feat/cache_formula_si
branch
from
2bed4a4 to
c85ade6
Compare
xuri
approved these changes
Apr 26, 2025
xuri
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
build Shared formula index, optimize performance of GetCellFormula
Related issues: https://github.com/qax-os/excelize/issues/1961
Description
Related Issue
#1961
On my pc, the test mentioned in the issue has been reduced from 27 seconds to 4 seconds
#2030
As discussed in #2030 , the deepcopy will use gitHub/mahae/deepcopy
Motivation and Context
How Has This Been Tested
Types of changes
Checklist