Skip to content

- added existence waiter before value waits to avoid promise reject w… #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

- added existence waiter before value waits to avoid promise reject w… #98

merged 2 commits into from
Dec 11, 2023

Conversation

@AlexGalichenko
Copy link
Contributor

@AlexGalichenko AlexGalichenko commented Dec 10, 2023 •
edited
Loading

Before submitting this PR, please ensure that you have completed the following:

  • Updated the CHANGELOG.md.
  • Checked that there aren't other open pull requests for the same issue/update.
  • Checked that your contribution follows the project's contribution guidelines.
  • Added corresponding unit/E2E tests
  • Unit and E2E pass

Description

  • added existence waiter before value waits to avoid promise reject without reason error
  • added restartBrowser config flag to restart browser between tests (default is false, considering restarting context)

- added existence waiter before value waits to avoid promise reject w…
f57a434 
…ithout reason error

- added _restartBrowser_ config flag to restart browser between tests (default is false, considering restarting context)
@AlexGalichenko AlexGalichenko added bug Something isn't working enhancement New feature or request labels Dec 10, 2023
@AlexGalichenko AlexGalichenko self-assigned this Dec 10, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@AlexGalichenko AlexGalichenko merged commit 6539a97 into main Dec 11, 2023
@AlexGalichenko AlexGalichenko deleted the fix-promise-with-no-reason branch December 11, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KirillBogdanets KirillBogdanets KirillBogdanets approved these changes

@ALegchilov ALegchilov Awaiting requested review from ALegchilov

Assignees

@AlexGalichenko AlexGalichenko

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexGalichenko @KirillBogdanets