Skip to content

fixed video attachment #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fixed video attachment #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to the "@qavajs/steps-playwright" will be documented in this

Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.

## [0.29.1]
- :beetle: fixed video attachment

## [0.29.0]
- :rocket: added _I save screenshot of {string} as {string}_ step

Expand Down
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,14 @@ module.exports = {

## Playwright traces
@qavajs support capturing playwright traces. https://playwright.dev/docs/next/trace-viewer-intro
Trace Viewer - https://trace.playwright.dev/

```typescript
export default {
//...
browser: {
trace: {
event: ['onFail'], // Events to save trace. Possible value onFail or AfterScenario
event: ['onFail'], // Events to save trace. Possible value onFail or afterScenario
dir: 'dirToStoreTraces', // Dir to store traces. Default is traces/
attach: true // Define if trace need to be attached to cucumber report. Default false
}
Expand All @@ -101,7 +103,7 @@ export default {
//...
browser: {
video: {
event: ['onFail'], // Events to save video. Possible value onFail or AfterScenario
event: ['onFail'], // Events to save video. Possible value onFail or afterScenario
dir: 'dirToStoreVideo', // Dir to store video. Default is video/
size: { width: 640, height: 480 }, // Video resolution
attach: true // Define if trace need to be attached to cucumber report. Default false
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qavajs/steps-playwright",
"version": "0.29.0",
"version": "0.29.1",
"description": "steps to interact with playwright",
"main": "./index.js",
"scripts": {
Expand All @@ -27,7 +27,7 @@
"@qavajs/cli": "^0.27.0",
"@qavajs/console-formatter": "^0.5.0",
"@qavajs/html-formatter": "^0.13.0",
"@qavajs/memory": "^1.6.0",
"@qavajs/memory": "^1.6.1",
"@qavajs/po-playwright": "^0.11.0",
"@qavajs/webstorm-adapter": "^8.0.0",
"@qavajs/xunit-formatter": "^0.0.4",
Expand Down
6 changes: 3 additions & 3 deletions src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ export function saveTrace(driverConfig: any, scenario: ITestCaseHookParameter):
}

export function saveVideo(driverConfig: any, scenario: ITestCaseHookParameter): boolean {
return driverConfig?.trace && (
(equalOrIncludes(driverConfig?.trace.event, VideoEvent.AFTER_SCENARIO)) ||
(scenario.result?.status === Status.FAILED && equalOrIncludes(driverConfig?.trace.event, VideoEvent.ON_FAIL))
return driverConfig?.video && (
(equalOrIncludes(driverConfig?.video.event, VideoEvent.AFTER_SCENARIO)) ||
(scenario.result?.status === Status.FAILED && equalOrIncludes(driverConfig?.video.event, VideoEvent.ON_FAIL))
)
}

Expand Down