screenshot under root is marked as deprecated (#63)

Author: AlexGalichenko

CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to the "@qavajs/steps-playwright" will be documented in this
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
+:rocket: - new feature
+:beetle: - bugfix
+:x: - deprecation
+
+## [0.30.0]
+Deprecated:
+- :x: screenshot property moved to browser/driver config.
+  Screenshot under root is marked as deprecated and will be removed in future releases.
+ 
 ## [0.29.1]
 - :beetle: fixed video attachment
 

README.md

@@ -74,7 +74,9 @@ Supported events:
 ```javascript
 module.exports = {
     default: {
-        screenshot: ['onFail']
+        browser: {
+            screenshot: ['onFail']
+        }
     }
 }
 ```

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@qavajs/steps-playwright",
-  "version": "0.29.1",
+  "version": "0.30.0",
   "description": "steps to interact with playwright",
   "main": "./index.js",
   "scripts": {

package.json

@@ -5,13 +5,13 @@ import {Status, ITestStepHookParameter, ITestCaseHookParameter} from '@cucumber/
 import {join} from 'path';
 
 export function saveScreenshotAfterStep(config: any, step: ITestStepHookParameter): boolean {
-    const isAfterStepScreenshot = equalOrIncludes(config.screenshot, ScreenshotEvent.AFTER_STEP);
-    const isOnFailScreenshot = equalOrIncludes(config.screenshot, ScreenshotEvent.ON_FAIL);
+    const isAfterStepScreenshot = equalOrIncludes(config?.driverConfig.screenshot ?? config.screenshot, ScreenshotEvent.AFTER_STEP);
+    const isOnFailScreenshot = equalOrIncludes(config?.driverConfig.screenshot ?? config.screenshot, ScreenshotEvent.ON_FAIL);
     return (isOnFailScreenshot && step.result.status === Status.FAILED) || isAfterStepScreenshot
 }
 
 export function saveScreenshotBeforeStep(config: any): boolean {
-    return equalOrIncludes(config.screenshot, ScreenshotEvent.BEFORE_STEP)
+    return equalOrIncludes(config?.driverConfig.screenshot ?? config.screenshot, ScreenshotEvent.BEFORE_STEP)
 }
 
 export function saveTrace(driverConfig: any, scenario: ITestCaseHookParameter): boolean {

src/utils/utils.ts

@@ -23,7 +23,8 @@ const common = {
             dir: 'dirToStoreVideos',
             size: { width: 800, height: 600 },
             attach: true
-        }
+        },
+        screenshot: ['onFail'],
     },
     format: [
         '@qavajs/console-formatter',
@@ -36,7 +37,6 @@ const common = {
     publishQuiet: true,
     retry: 1,
     service: [localServer],
-    screenshot: ['onFail'],
     tags: 'not @skip'
 }