fixed video attachment (#62)

Author: AlexGalichenko

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to the "@qavajs/steps-playwright" will be documented in this
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
+## [0.29.1]
+- :beetle: fixed video attachment
+
 ## [0.29.0]
 - :rocket: added _I save screenshot of {string} as {string}_ step
 

README.md

@@ -81,12 +81,14 @@ module.exports = {
 
 ## Playwright traces
 @qavajs support capturing playwright traces. https://playwright.dev/docs/next/trace-viewer-intro
+Trace Viewer - https://trace.playwright.dev/
+
 ```typescript
 export default {
     //...
     browser: {
         trace: {
-            event: ['onFail'], // Events to save trace. Possible value onFail or AfterScenario 
+            event: ['onFail'], // Events to save trace. Possible value onFail or afterScenario 
             dir: 'dirToStoreTraces', // Dir to store traces. Default is traces/
             attach: true // Define if trace need to be attached to cucumber report. Default false
         }
@@ -101,7 +103,7 @@ export default {
     //...
     browser: {
         video: {
-            event: ['onFail'], // Events to save video. Possible value onFail or AfterScenario 
+            event: ['onFail'], // Events to save video. Possible value onFail or afterScenario 
             dir: 'dirToStoreVideo', // Dir to store video. Default is video/
             size: { width: 640, height: 480 }, // Video resolution
             attach: true // Define if trace need to be attached to cucumber report. Default false

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@qavajs/steps-playwright",
-  "version": "0.29.0",
+  "version": "0.29.1",
   "description": "steps to interact with playwright",
   "main": "./index.js",
   "scripts": {
@@ -27,7 +27,7 @@
     "@qavajs/cli": "^0.27.0",
     "@qavajs/console-formatter": "^0.5.0",
     "@qavajs/html-formatter": "^0.13.0",
-    "@qavajs/memory": "^1.6.0",
+    "@qavajs/memory": "^1.6.1",
     "@qavajs/po-playwright": "^0.11.0",
     "@qavajs/webstorm-adapter": "^8.0.0",
     "@qavajs/xunit-formatter": "^0.0.4",

package.json

@@ -22,9 +22,9 @@ export function saveTrace(driverConfig: any, scenario: ITestCaseHookParameter):
 }
 
 export function saveVideo(driverConfig: any, scenario: ITestCaseHookParameter): boolean {
-    return driverConfig?.trace && (
-        (equalOrIncludes(driverConfig?.trace.event, VideoEvent.AFTER_SCENARIO)) ||
-        (scenario.result?.status === Status.FAILED && equalOrIncludes(driverConfig?.trace.event, VideoEvent.ON_FAIL))
+    return driverConfig?.video && (
+        (equalOrIncludes(driverConfig?.video.event, VideoEvent.AFTER_SCENARIO)) ||
+        (scenario.result?.status === Status.FAILED && equalOrIncludes(driverConfig?.video.event, VideoEvent.ON_FAIL))
     )
 }