Skip to content

feat: all the destinations should be computed automatically #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 10, 2023
Merged

feat: all the destinations should be computed automatically #31

merged 15 commits into from
May 10, 2023

Conversation

qascade
Copy link
Owner

@qascade qascade commented May 4, 2023

Description

This PR automates the computation of destinations with only config yaml as input.
Solves: #27

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • Does this code have any breaking changes?
  • Does this code have any yaml schema changes?

Screenshots

Put any screenshot(s) of the project here.

@qascade qascade self-assigned this May 4, 2023
@qascade qascade added the enhancement New feature or request label May 4, 2023
@qascade qascade changed the title feat: All the destinations should be computed with only collaboration package as an input. feat: all the destinations should be computed automatically May 4, 2023
@tipped73 tipped73 self-requested a review May 10, 2023 22:31
tipped73
tipped73 approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@tipped73 tipped73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tipped73 tipped73 self-requested a review May 10, 2023 22:59
tipped73
tipped73 approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@tipped73 tipped73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qascade qascade merged commit 5a73a2b into main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipped73 tipped73 tipped73 approved these changes

Assignees

@qascade qascade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qascade @tipped73