-
Notifications
You must be signed in to change notification settings - Fork 16
feat: enable use of collaboration package in dcr #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Added functionality to parse yaml file and extract data * completed verification * changed contract info and tested verification * added upload utility and tested manually * added env file and delete utility * nitpicks * fixes * refactor: moved verification to package collaboration and added draft tests for verification * refactor: moved verification to package collaboration and added draft tests for verification * added verify to cli and completed verification * Utilites: Added terminate and upload cli --------- Co-authored-by: Shubh Karman Singh <54154054+qascade@users.noreply.github.com>
…Interface and modified test files
39d223a
to
132e5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the errors, follow the comments, and make the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This PR will implement the Parsing, Validation, and Verification of the yaml files in Collaboration Package. This includes defining basic structure for the collaboration package.