Skip to content

feat: enable use of collaboration package in dcr #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 17, 2023

Conversation

qascade
Copy link
Owner

@qascade qascade commented Mar 5, 2023

This PR will implement the Parsing, Validation, and Verification of the yaml files in Collaboration Package. This includes defining basic structure for the collaboration package.

@qascade qascade requested a review from tiklup11 March 5, 2023 23:02
@qascade qascade linked an issue Mar 5, 2023 that may be closed by this pull request
@qascade qascade added the enhancement New feature or request label Mar 5, 2023
@qascade qascade self-assigned this Mar 5, 2023
@qascade qascade added the draft label Mar 5, 2023
@qascade qascade changed the title feat: defined structs for contract package feat: enable use of collaboration package in dcr Mar 6, 2023
Copy link
Collaborator

@tiklup11 tiklup11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qascade qascade changed the base branch from feat.dcr-cli to main March 8, 2023 19:50
tiklup11 and others added 10 commits March 9, 2023 01:25
* Added functionality to parse yaml file and extract data

* completed verification

* changed contract info and tested verification

* added upload utility and tested manually

* added env file and delete utility

* nitpicks

* fixes

* refactor: moved verification to package collaboration and added draft tests for verification

* refactor: moved verification to package collaboration and added draft tests for verification

* added verify to cli and completed verification

* Utilites: Added terminate and upload cli

---------

Co-authored-by: Shubh Karman Singh <54154054+qascade@users.noreply.github.com>
@qascade qascade force-pushed the feat.collaboration_package_parsing branch from 39d223a to 132e5ff Compare March 8, 2023 20:00
@qascade qascade requested a review from ShisuiMadara March 8, 2023 20:02
Copy link
Collaborator

@ShisuiMadara ShisuiMadara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the errors, follow the comments, and make the tests pass.

Copy link
Collaborator

@tiklup11 tiklup11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@qascade qascade merged commit d570f1e into main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specs: Support for contract package.
3 participants