Update ImagePipe #705
Merged
Update ImagePipe #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted also update Bincode, since updating it is not so trivial, but for now this bug prevents from doing this - bincode-org/bincode#537
Fixes: #696
Fixes: #690 - reported abonander/mime_guess#72
Fixes: #699
Fixes bug when audio with lower than 1s length was visible without length(now is 0:01).
Also shows in parentheses which exactly extensions was found by bad extensions tool.
Changed also Rodio to my own crate to open and check audio files(a lot of dependencies was deleted)
Added support for finding invalid PDF files(new unreleased version will provide a lot of more complete support)
Also updated minimal Rust version to 1.60 which is not yet available in Ubuntu, but it will be someday.
Waiting(in next PR) for updating:
Lofty-rs 0.6.3 - parses more files(unreleased and have more regressions)
Waiting for pdeljanov/Symphonia#122, but for now I handle crashes in normal builds, so it is not so important, because for now it will just print to output info about not proper data.