-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flatpak support #203
Add Flatpak support #203
Conversation
Great work! I tested it and looks that everything works - file deletion, previews, cache, saving/loading config etc. I was able to install it but without --user flag and with sudo permissions |
That's fine. When you want to install a flatpak in your user, you need to add the repository in your user as well. So in this case, you need to install Flathub with That was my fault. I usually install flatpaks with Also, it's good to know it's working. I couldn't easily tell if it was working or not on my end. |
@qarmin keep in mind that we made it easy to publish it in Flathub since the flatpak doesn't download during the build process (for redistribution purposes). I can help you with publishing it in Flathub if you want. |
It would be great. I published now a new Czkawka version, because adds Alsa dependency needed by external library(Czkawka doesn't play any sounds just decode audio), New version will require rebuild of cargo-sources.json and probably will require also adding some
I tried to test it, but I couldn't find any method to create json cargo sources file. |
I updated its permissions and bumped it. Tell me how that goes.
Here's how to do it: Download the python ./flatpak-cargo-generator.py ./Cargo.lock -o flatpak/cargo-sources.json Lastly run flatpak-builder --force-clean --install-deps-from=flathub --install build-dir flatpak/com.github.qarmin.Czkawka.yaml (from the root of the source code). |
Thanks, I checked Looks that for now this Flatpak package provides more functionality than current Snap package which have missing support for external drives and some hidden folders in |
@qarmin by default, cd6a589 won't work since it asks for cd6a589#diff-55e4c74d40f6d322fcee02c419923278516387286a39e8daa8de64e0039a3328R29, which will only be available once this MR is merged. You can either comment that line or change the last two lines to: - url: https://github.com/qarmin/czkawka.git
- tag: 2.3.0
+ url: https://github.com/TheEvilSkeleton/czkawka.git |
@qarmin feel free to merge it. I think it's good to go. Also, I'm pretty sure this will be accepted in Flathub right off the bat. |
Thanks! |
Keep in mind that this should be accepted in Flathub with minor changes needed at best. You just:
|
Oh right... I completely forgot that since the tag is from |
Related to #15
I managed to make the GUI work,
but I don't think it deletes the files when I tell it to.it works!This is just an initial flatpak. I'll try to get it to work if others are willing to help.
If you want to test out the flatpak, make sure you have
flatpak-builder
installed, and run the following commands:git clone https://github.com/TheEvilSkeleton/czkawka cd czkawka/flatpak flatpak-builder --force-clean --install-deps-from=flathub --install build-dir com.github.qarmin.Czkawka.yaml
P.S. if you have any suggestions, feel free to comment.