Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows implementation of filter_hard_links() function #1316

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

CalunVier
Copy link
Contributor

Implementation of czkawka_core/src/duplicate.rs filter_hard_links(), with new crate file_id 0.2.1.

Krokiet for Windows has been compiled and tested and works fine. However, due to Cargo.lock, Github Action cannot compile the GTK version. I don't have a Rust programming environment on my local machine, so I can't configure it. This part needs the help of the project maintainer.

Implementation of czkawka_core/src/duplicate.rs filter_hard_links(), with new crate file_id 0.2.1 (Don't update anymore! This crate has a bug. I've submitted a patch upstream, but the change is breaking. The current code relies on the bug to work correctly!)
@CalunVier
Copy link
Contributor Author

#1267

@CalunVier
Copy link
Contributor Author

My friend helped me update Cargo.lock, but one compilation failed even though there were no errors in the program, and I'm not sure why. It seems that the Github Action timed out.

@CalunVier
Copy link
Contributor Author

My friend helped me update Cargo.lock, but one compilation failed even though there were no errors in the program, and I'm not sure why. It seems that the Github Action timed out.

Ummmm, it seems like there is something wrong. My friend and I are not very proficient in rust, so I surrender. Before merging, other users can go to my forked action to get the Windows package.

@qarmin qarmin merged commit ad832ea into qarmin:master Sep 26, 2024
17 of 18 checks passed
@qarmin
Copy link
Owner

qarmin commented Sep 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants