Handle the outdir option consistently #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outdir option was being expanded to the full path for the purposes of checking output files, but the relative path was being passed into the asn1 compiler. This created some unexpected results when the plugin was being used to compile a dependency. The output files were being placed in a directory at the top level of the project when they should be in a directory relative to the dependency. Also, use 'filelib:ensure_dir' to create parent directories, if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outdir option was being expanded to the full path for the purposes of checking output files, but the relative path was being passed into the asn1 compiler. This created some unexpected results when the plugin was being used to compile a dependency. The output files were being placed in a directory at the top level of the project when they should be in a directory relative to the dependency.
Also, use 'filelib:ensure_dir' to create parent directories, if necessary.