-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimal version of orix to >= 0.11.1 #623
Conversation
Version 0.11.1 includes a bug fix for where phases were losing information after refinement from single crystal map.
Thank you for reporting #620 which lead to the fix in orix 0.11.1 and then this PR! Would be nice if you could add a one-liner under "Changed" in I'll add your name (Erlend Mikkelsen Østvold) to the package credits in |
Yes! I thought maybe I had to create the pull request first in order to refer to it in the changelog. I am ok with being added to contributers, thank you. |
True, the manual way we create the changelog isn't perhaps the most convenient... I determine the next GitHub repo ID by checking the latest IDs among issues, PRs and discussions. But this procedure isn't written anywhere... Just ping me when the PR is ready for review (should be quick)! |
@hakonanes The PR should be ready for review now!:) |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Next time, I suggest to name your branch something else than |
Description of the change
Set minimal version of orix to >= 0.11.1
For reviewers
__init__.py
.section in
CHANGELOG.rst
.release.py
,.zenodo.json
and.all-contributorsrc
with the table regenerated.