Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor xdrlib #402

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Vendor xdrlib #402

merged 2 commits into from
Nov 27, 2023

Conversation

MatthieuDartiailh
Copy link
Member

Python 3.13 removes xdrlib so we will simply vendor the module.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (09d9c67) 24.22% compared to head (b60ba92) 24.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   24.22%   24.81%   +0.59%     
==========================================
  Files          24       25       +1     
  Lines        3356     3526     +170     
  Branches      469      490      +21     
==========================================
+ Hits          813      875      +62     
- Misses       2524     2632     +108     
  Partials       19       19              
Flag Coverage Δ
unittests 24.81% <36.84%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyvisa_py/protocols/rpc.py 21.99% <100.00%> (ø)
pyvisa_py/protocols/xdrlib.py 36.47% <36.47%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthieuDartiailh MatthieuDartiailh merged commit 91332c9 into main Nov 27, 2023
20 of 21 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the vendor-xdrlib branch November 27, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant