Fix the parallax correction code for the unit and computation of satellite altitude #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and not kilometers
… in meters consistently with the orbital_parameters
…smaller since the earth radius was added to the sat position
|
cc @jequierz |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 463 463
Lines 58151 58151
=======================================
Hits 56015 56015
Misses 2136 2136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17242360245Details
💛 - Coveralls |
|
Great work! Thank you Andrea :) |
gerritholl
approved these changes
Sep 3, 2025
|
|
||
| val = get_surface_parallax_displacement( | ||
| 0, 0, 36_000_000, 0, 10, 10_000) | ||
| np.testing.assert_allclose(val, 2141.2404451757875) |
There was a problem hiding this comment.
Nice, this tells us how far we were off :) 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two aspects in the parallax correction code
it fixes and uniformises the usage of meters for the satellite/platform altitude
add the Earth radius to the satellite altitude to correctly compute the cartesian satellite coordinates
Closes Wrong satellite altitude units in parallax correction computation and
get_satposdocstring #3182 Earth radius missing in sat_xyz computation in parallax modifier #3151Tests added
Fully documented