Skip to content

Fix plugin tests not completely cleaning up after themselves #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 26, 2025

We've had occasional test failures related to a missing "satpy_plugin". This seemed like a race condition by the pytest-xdist parallel test execution and some test corrupting other tests. Now that I tracked it down I think it could have happened if regular pytest execution ordered the tests differently. Basically the plugin tests were cleaning up the entry points cache before tests but they should have been doing it after the tests. This PR fixes that.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (14c9f38) to head (869e4fe).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3074      +/-   ##
==========================================
+ Coverage   96.11%   96.13%   +0.01%     
==========================================
  Files         383      383              
  Lines       55685    55688       +3     
==========================================
+ Hits        53523    53534      +11     
+ Misses       2162     2154       -8     
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.01%) ⬇️
unittests 96.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese merged commit ef3618f into pytroll:main Feb 26, 2025
17 of 18 checks passed
@djhoese djhoese deleted the bugfix-config-racecond branch February 26, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants