Skip to content

Prevent call to obj.__dict__ when obj is a compound variable. #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

mataeui
Copy link
Contributor

@mataeui mataeui commented Feb 20, 2025

@djhoese djhoese changed the title #3066 Prevent call to obj.__dict__ when obj is a compound variable. Prevent call to obj.__dict__ when obj is a compound variable. Feb 20, 2025
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this fix. I have a few comments below.

@mataeui mataeui force-pushed the main branch 4 times, most recently from 2953e33 to 26aa442 Compare February 20, 2025 18:52
@mataeui
Copy link
Contributor Author

mataeui commented Feb 21, 2025

I assume that:

docs/readthedocs.org:satpy — Read the Docs build failed!

Is nothing to do with me.

@djhoese
Copy link
Member

djhoese commented Feb 21, 2025

Correct. It's a bug/memory leak in the new version of sphinx that I'm working on fixing.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (17cf0ce) to head (128bb9e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/netcdf_utils.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3069   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         383      383           
  Lines       55785    55798   +13     
=======================================
+ Hits        53636    53649   +13     
  Misses       2149     2149           
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.01%) ⬇️
unittests 96.24% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese djhoese self-assigned this Feb 28, 2025
@djhoese djhoese merged commit faec582 into pytroll:main Feb 28, 2025
16 of 18 checks passed
@djhoese
Copy link
Member

djhoese commented Feb 28, 2025

Thanks @mataeui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetCDF4FileHandler faults when using obj.__dict__ called when object is a compound variable.
2 participants