-
Notifications
You must be signed in to change notification settings - Fork 307
Prevent call to obj.__dict__ when obj is a compound variable. #3069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this fix. I have a few comments below.
2953e33
to
26aa442
Compare
I assume that: docs/readthedocs.org:satpy — Read the Docs build failed! Is nothing to do with me. |
Correct. It's a bug/memory leak in the new version of sphinx that I'm working on fixing. |
…butes on failure.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 383 383
Lines 55785 55798 +13
=======================================
+ Hits 53636 53649 +13
Misses 2149 2149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @mataeui! |
AUTHORS.md
if not there already