-
Notifications
You must be signed in to change notification settings - Fork 307
Add more datasets to IASI L2 reader #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more datasets to IASI L2 reader #3059
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
+ Coverage 96.11% 96.15% +0.03%
==========================================
Files 383 383
Lines 55673 55822 +149
==========================================
+ Hits 53511 53674 +163
+ Misses 2162 2148 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one small request that is not necessary would be rewriting most if not all of the test setup as a pytest fixture. You could have one that just produces the filename (Path
object?) and is module scoped. Then have one that produces a Scene and one that produces a file handler (replaces self.reader
) that are test scoped. That way any caching inside the Scene or file handler are not preserved between tests, but the test file is only created once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've now removed the test class and replaced the |
Ok, found the |
Pull Request Test Coverage Report for Build 13989982277Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cc64efc
to
4053955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds datasets from
/INFO/
and/Maps/
groups to the IASI L2 reader.Also the IASI L2 tests were converted to pytest.