Skip to content

Add reader for CAMEL emissivity datasets. #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2025
Merged

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Dec 28, 2024

This PR adds a reader for the NASA / USGS CAMEL emissivity product, which is a Level 3 global, gridded, dataset of IR emissivity values at 13 spectral tie points.

As well as the emissivity data, this reader also supports the ancillary datasets (ndvi, quality flags, etc).

  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (869e4fe) to head (0a5720e).
Report is 92 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3023    +/-   ##
========================================
  Coverage   96.13%   96.13%            
========================================
  Files         383      385     +2     
  Lines       55688    55802   +114     
========================================
+ Hits        53534    53648   +114     
  Misses       2154     2154            
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.01%) ⬇️
unittests 96.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Dec 28, 2024

Pull Request Test Coverage Report for Build 12648250966

Details

  • 115 of 115 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 96.2%

Totals Coverage Status
Change from base Build 12572361608: 0.008%
Covered Lines: 53363
Relevant Lines: 55471

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments inline.

simonrp84 and others added 2 commits December 30, 2024 10:22
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
@simonrp84
Copy link
Member Author

Thanks @pnuu! I've committed some changes that should address your comments.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Mar 21, 2025
@mraspaud mraspaud merged commit 28a59f1 into pytroll:main Mar 21, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants