Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash age compositor for li instruments #2895

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ClementLaplace
Copy link
Contributor

@ClementLaplace ClementLaplace commented Sep 4, 2024

This Merge request is there to create the flash age compositor related to the li instrument.

  • Add the flash_age compositor feature
  • Document the code related to the feature
  • Test the flash_age compositor

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (084b114) to head (3edf893).
Report is 131 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2895    +/-   ##
========================================
  Coverage   96.06%   96.07%            
========================================
  Files         370      375     +5     
  Lines       54320    54474   +154     
========================================
+ Hits        52185    52335   +150     
- Misses       2135     2139     +4     
Flag Coverage Δ
behaviourtests 3.98% <0.00%> (-0.02%) ⬇️
unittests 96.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10700852657

Details

  • 18 of 34 (52.94%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on add_flash_age_compositor at 96.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/composites/lightning.py 18 34 52.94%
Totals Coverage Status
Change from base Build 10654375136: 96.1%
Covered Lines: 52426
Relevant Lines: 54540

💛 - Coveralls

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this first draft! I left a comment regarding the reference time.

satpy/composites/lightning.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants