-
Notifications
You must be signed in to change notification settings - Fork 307
Fix AAPP L1b reader not to up-cast data to float64 #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
==========================================
- Coverage 96.06% 96.05% -0.02%
==========================================
Files 370 370
Lines 54320 54334 +14
==========================================
+ Hits 52185 52191 +6
- Misses 2135 2143 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10664568987Details
💛 - Coveralls |
@mraspaud ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pnuu any idea how long this upcasting had been going on? After this PR some integration tests of mine for my Polar2Grid project are showing ~11% of pixels being slightly different. I don't think I'm using numpy 2 yet so does that mean this upcasting has been going on for many years? |
And to look further, prior to that the dtype had been |
The
aapp_l1b
reader was returning the data asfloat64
. This PR forces the data tofloat32
.AUTHORS.md
if not there already