New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "performance_test" to the benchmarks #2847

Open

yukaribbba wants to merge 36 commits into pytroll:main from yukaribbba:add_performance_tests_to_docs

Open

Add "performance_test" to the benchmarks #2847

Merge branch 'pytroll:main' into add_performance_tests_to_docs

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jul 9, 2024 in 42s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.69 (10.00 -> 9.31)

Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

Deep, Nested Complexity performance_test.py: SatpyPerformanceTest.resampler_test
Excess Number of Function Arguments performance_test.py: SatpyPerformanceTest.init

Annotations

Check warning on line 251 in benchmarks/performance_test.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

SatpyPerformanceTest.resampler_test has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 80 in benchmarks/performance_test.py

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

SatpyPerformanceTest.__init__ has 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

View more details on CodeScene Delta Analysis