Skip to content

Commit

Permalink
Fix optional kwarg in MSI SAFE reader.
Browse files Browse the repository at this point in the history
  • Loading branch information
simonrp84 committed Apr 7, 2024
1 parent e722e9f commit 89a75cf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions satpy/readers/msi_safe.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
"""

import logging
from datetime import datetime

import dask.array as da
from datetime import datetime
import defusedxml.ElementTree as ET
import numpy as np
import xarray as xr
Expand Down Expand Up @@ -123,7 +123,7 @@ def get_area_def(self, dsid):
class SAFEMSIXMLMetadata(BaseFileHandler):
"""Base class for SAFE MSI XML metadata filehandlers."""

def __init__(self, filename, filename_info, filetype_info, mask_saturated=True):
def __init__(self, filename, filename_info, filetype_info, mask_saturated=True, use_tile_time=False):

Check notice on line 126 in satpy/readers/msi_safe.py

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Excess Number of Function Arguments

SAFEMSIXMLMetadata.__init__ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
"""Init the reader."""
super().__init__(filename, filename_info, filetype_info)
self._start_time = filename_info["observation_time"]
Expand Down Expand Up @@ -239,7 +239,7 @@ def _fill_swath_edges(angles):
class SAFEMSITileMDXML(SAFEMSIXMLMetadata):
"""File handle for sentinel 2 safe XML tile metadata."""

def __init__(self, filename, filename_info, filetype_info, mask_saturated=True):
def __init__(self, filename, filename_info, filetype_info, mask_saturated=True, use_tile_time=False):

Check notice on line 242 in satpy/readers/msi_safe.py

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Excess Number of Function Arguments

SAFEMSITileMDXML.__init__ has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
"""Init the reader."""
super().__init__(filename, filename_info, filetype_info, mask_saturated)
self.geocoding = self.root.find(".//Tile_Geocoding")
Expand Down Expand Up @@ -282,7 +282,7 @@ def _shape(self, resolution):

def start_time(self):
"""Get the observation time from the tile metadata."""
timestr = self.root.find('.//SENSING_TIME').text
timestr = self.root.find(".//SENSING_TIME").text
return datetime.strptime(timestr, "%Y-%m-%dT%H:%M:%S.%fZ")

@staticmethod
Expand Down

0 comments on commit 89a75cf

Please sign in to comment.