Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype preservation in astronomy functions #156

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 26, 2024

Redo of #155 without type annotation

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes flake8 pyorbital
  • Fully documented

@djhoese djhoese added the bug label Jun 26, 2024
@djhoese djhoese self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 90.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (18340ca) to head (3247b15).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
pyorbital/astronomy.py 88.23% 4 Missing ⚠️
pyorbital/tests/test_astronomy.py 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   87.51%   87.99%   +0.48%     
==========================================
  Files          14       14              
  Lines        2210     2241      +31     
==========================================
+ Hits         1934     1972      +38     
+ Misses        276      269       -7     
Flag Coverage Δ
unittests 87.99% <90.66%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.933% (+0.4%) from 87.562%
when pulling 3247b15 on djhoese:bugfix-dtype-promotion2
into 83e029a on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Jun 26, 2024

As discussed on slack, I've got the OK to merge this since it just includes the "good" parts of the other PR.

@djhoese djhoese merged commit e68d5c8 into pytroll:main Jun 26, 2024
17 checks passed
@djhoese djhoese deleted the bugfix-dtype-promotion2 branch June 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants