Run cythonize upon build #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamklob
force-pushed
the
fix-python-37-build
branch
3 times, most recently
from
8867f60 to
9909ddc
Compare
iamklob
force-pushed
the
fix-python-37-build
branch
from
9909ddc to
d65d91d
Compare
iamklob
force-pushed
the
fix-python-37-build
branch
from
d65d91d to
1a4f2c5
Compare
Contributor
Author
|
@superbobry Hi! Any chance this will get merged? |
|
Yes, this is breaking any dependent builds... Please fix |
|
what checks? |
jdufresne
approved these changes
Jan 5, 2019
superbobry
reviewed
Jan 7, 2019
|
|
||
| setup_requires=["pytest-runner"], | ||
| ext_modules=ext_modules, | ||
| setup_requires=["pytest-runner", 'Cython>=0.28;python_version<="3.7"'], |
Member
There was a problem hiding this comment.
Is there a reason to upper-bound the version here?
Contributor
|
This got merged in #80 . Thank you for your work on this @akloboucnik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue #52