Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive "Modularize zero step function and make it customizable" #7233 #8332

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Revive "Modularize zero step function and make it customizable" #7233 #8332

wants to merge 5 commits into from

Commits on Oct 29, 2024

  1. Modularize zero step function and make it customizable (#7233)

    @karakusc @jeffhataws
    karakusc authored and jeffhataws committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    883fafd View commit details
    Browse the repository at this point in the history

  2. small fix to pass sharding_scheme instead of **kwargs 

    cr: https://code.amazon.com/reviews/CR-132179892
    @jeffhataws
    Karakus authored and jeffhataws committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6abb432 View commit details
    Browse the repository at this point in the history

  3. make method signatures consistent with oss

    @jeffhataws
    Karakus authored and jeffhataws committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fe38795 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Lint fixes

    @jeffhataws
    jeffhataws committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a69351b View commit details
    Browse the repository at this point in the history

  2. Fixing missing sharding_scheme param (#8341)

    @slabhs @jeffhataws
    slabhs authored and jeffhataws committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    946fa8a View commit details
    Browse the repository at this point in the history