Extend paged attention to support query_len>1 #8328
Merged
+1,130
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
commented
Oct 28, 2024
| page_indices, # [batch_size, pages_per_sequence] | ||
| num_kv_pages_per_compute_block, | ||
| num_queries_per_compute_block, | ||
| use_kernel=True, |
There was a problem hiding this comment.
hey @WoosukKwon, this is the integration point between vLLM and torch_xla. I'm thinking if vLLM can switch this flag use_kernel perhaps by using some flags. I want to use the nonkernel version as a per baseline. Do you know if it possible?
There was a problem hiding this comment.
For dynamo, it's similar. The integration point is at def multi_queries_paged_attention_xla( in the same file.
Liyang90
reviewed
Oct 28, 2024
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Show resolved
Hide resolved
torch_xla/experimental/pallas_kernels/multi_queries_paged_attention_kernel.py
Outdated
Show resolved
Hide resolved
vanbasten23
commented
Oct 28, 2024
Liyang90
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the existing paged attention kernel to support query_len>1. Additionally, it upgrades the flash attention from v1 to v2.
Test plan:
cc: @miladm