Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch_xla2] Fix scatter and scatter_add #8045

Merged
merged 4 commits into from
Sep 23, 2024
Merged

[torch_xla2] Fix scatter and scatter_add #8045

merged 4 commits into from
Sep 23, 2024

Conversation

dvhg
Copy link
Contributor

@dvhg dvhg commented Sep 19, 2024 •
edited
Loading

This fixes the op test for scatter and scatter_add. scatter_reduce is still broken as include_self = False is unsupported.

@dvhg dvhg changed the title Fix negative dims in scatter_index [torch_xla2] Fix scatter and scatter_add Sep 20, 2024
ManfeiBai
ManfeiBai approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ManfeiBai
Copy link
Collaborator

Thanks for the contribution, @dvhg, please feel free to create a issue with name [hard] for scatter_reduce, and mention include_self = False affect its implementation

@ManfeiBai ManfeiBai merged commit 2aea97a into pytorch:master Sep 23, 2024
3 checks passed
@dvhg dvhg mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfeiBai ManfeiBai ManfeiBai approved these changes

Assignees
No one assigned
Labels
torchxla2-op torchxla2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvhg @ManfeiBai