Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CUDA plugin before torch and torch_xla in nightly build #7721

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

will-cromar
Copy link
Collaborator

@will-cromar will-cromar commented Jul 22, 2024

The nightly CUDA package build is failing with this error:

Step #2 - "build_xla_docker_image":       Error in repository_rule: invalid repository name '@pypi_torch_nightly+20240722_cp311_cp311_linux_x86_64_whl'

AFAICT this is happening because the build_srcs step is producing incorrectly-named wheels (see #7697). The GPU plugin build has zero dependency on PyTorch at all -- it builds completely separately in our CI. I believe it is unfortunately getting pulled in transitively through OpenXLAs build rules:

xla/WORKSPACE

Line 100 in 5ea4535

local_wheel_workspaces = ["@torch//:WORKSPACE"],

Move the plugin build to happen first as a temporary fix since there's no dependency between these steps.

Triggering the nightly build manually to see if this works

@will-cromar will-cromar marked this pull request as ready for review July 22, 2024 23:58
@will-cromar
Copy link
Collaborator Author

The test build passed. This PR should unbreak the GPU build.

@will-cromar will-cromar merged commit 42aa7bd into master Jul 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants