Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Modularize zero step function and make it customizable" #7259

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

JackCaoG
Copy link
Collaborator

Reverts #7233

break CI

======================================================================
ERROR: test_zero1 (__mp_main__.XlaZeRO1Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/xla/xla/pytorch/xla/test/test_zero1.py", line 59, in test_zero1
    opt2.step()
  File "/usr/local/lib/python3.10/site-packages/torch/optim/optimizer.py", line 484, in wrapper
    out = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch_xla/distributed/zero_redundancy_optimizer.py", line 433, in step
    self._update_parameters(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch_xla/distributed/zero_redundancy_optimizer.py", line 410, in _update_parameters
    self.allgather_weights_and_update_full_parameter()
  File "/usr/local/lib/python3.10/site-packages/torch_xla/distributed/zero_redundancy_optimizer.py", line 438, in allgather_weights_and_update_full_parameter
    sharding_scheme = self._get_sharding_scheme(**kwargs)
NameError: name 'kwargs' is not defined

----------------------------------------------------------------------

Please create from branch directly so CI can be run. I can give write access if needed.

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@JackCaoG JackCaoG merged commit ea2a6f7 into master Jun 12, 2024
5 checks passed
@JackCaoG
Copy link
Collaborator Author

cc @jeffhataws @karakusc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants