Remove obsolete FIXME in autoaugment.py#9496
Conversation
The FIXME above AutoAugment proposed extracting a shared _AutoAugmentBase to deduplicate fill standardization across the v1 AutoAugment, RandAugment, TrivialAugmentWide, and AugMix classes. Per maintainer guidance in pytorch#9447, v1 transforms are in maintenance mode and v2 (which already has _AutoAugmentBase) is where new work happens, so this refactor will not be done in v1. Removing the FIXME to reflect that decision. Closes pytorch#9446. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9496
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @joannemiki57! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
Removes the FIXME comment at
torchvision/transforms/autoaugment.py:103:The FIXME proposed extracting a shared
_AutoAugmentBaseto deduplicate the fill-standardization logic thatAutoAugment,RandAugment,TrivialAugmentWide, andAugMixeach implement in v1. The v2 transforms intorchvision/transforms/v2/_auto_augment.pyalready have this base class, so the refactor only ever made sense for v1.Per maintainer guidance in #9447:
Since #9447 has been inactive for over a month after that follow-up, opening this as a minimal alternative that matches exactly what the maintainer asked for: removing the FIXME to reflect that the refactor will not be done in v1. Happy to defer to #9447 if it becomes active again.
Changes
torchvision/transforms/autoaugment.py. No code or behavior changes.Closes #9446.
Test plan