-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Fast rotation for right angles #8295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3c5b5b2
add rotation fast path
pchain-thien 8652144
Merge branch 'pytorch:main' into main
gau-nernst cb4f943
remove PIL fast path
gau-nernst dbb36a8
return clone() for angle=0
gau-nernst f4d9e00
fix torchscript (and typing)
gau-nernst 7cad321
remove expand check for fast path
gau-nernst dbde073
Merge branch 'main' into main
gau-nernst 872d4c4
add test
gau-nernst 10f51bd
Merge branch 'main' into main
gau-nernst 1860a1f
Merge branch 'main' into main
gau-nernst 53f6c92
Merge branch 'main' into main
gau-nernst 154d715
fix fast path
gau-nernst 4260a3b
Merge branch 'main' into main
gau-nernst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
if expand
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading the NOTE section of
v2.RandomRotation
, and it says thatFrom what I understand, if
expand=True
, we can ignorecenter
, and thus we can safely usetorch.rot90()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove
expand
from the check