Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error condition for 'max_size' in '_compute_resized_output_size' #7984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

developer0hye
Copy link
Contributor

@developer0hye developer0hye commented Sep 23, 2023

requested_new_short can be the same with max_size.

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7984

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 2 Unrelated Failures

As of commit db49103 with merge base 35677ec (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @developer0hye. What issue are you trying to solve here? This change would be BC breaking. So unless there is a bug that we missed, we unfortunately can't accept this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants